If you want to do all the big York sites - Minster, Dungeons, Jorvik, Castle Museum...this is the best option!! We worked out that without the York Pass we'd have paid double for enterance fees to attractions!!
Also includes great discounts at lovely restaurants - Strada, Russels etc. AND!! Its well known in York so you dont feel silly showing the pass! Very simple to collect from Tourist Centre so dont pay for p&p. Enjoy!